Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache][HttpClient] Made method signatures compatible with their corresponding traits #36908

Merged

Conversation

derrabus
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #36872
License MIT
Doc PR N/A

Apparently, php 8 is less forgiving about method signature differences between a trait and the class that uses the trait. This PR makes minimal adjustments to get rid of fatal errors triggered by php 8.

@derrabus derrabus force-pushed the bugfix/compatible-trait-signatures branch from b4e41fc to 6fda276 Compare May 22, 2020 20:05
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 23, 2020
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit a25e88b into symfony:4.4 May 23, 2020
@derrabus derrabus deleted the bugfix/compatible-trait-signatures branch May 23, 2020 07:39
nicolas-grekas added a commit that referenced this pull request May 24, 2020
…ling in php 8 (derrabus)

This PR was merged into the 5.1 branch.

Discussion
----------

[HttpClient] Adjust AmpResponse to the stricter trait handling in php 8

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

Follows #36908.

Commits
-------

e3aa78f [HttpClient] Adjust AmpResponse to the stricter trait handling in php 8.
This was referenced May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants