Parse and render anonymous classes correctly on php 8 #36914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/render-anonymous-class
branch
from
2a057ad
to
6669181
Compare
derrabus
force-pushed
the
bugfix/render-anonymous-class
branch
from
6669181
to
d362a7c
Compare
derrabus
force-pushed
the
bugfix/render-anonymous-class
branch
3 times, most recently
from
ce625dc
to
f2fccb4
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
bugfix/render-anonymous-class
branch
from
f2fccb4
to
c23c5af
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
bugfix/render-anonymous-class
branch
from
c23c5af
to
9d702fd
Compare
|
Thank you @derrabus. |
This was referenced May 26, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of the value that
get_class()returns for anonymous classes has changed in php 8. This PR attempts to detect both formats, with the help of the PHP80 polyfill where possible.