[Security] Fixed handling of CSRF logout error #36974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
issue-36814/handle-logout-csrf-exception
branch
from
27d6697
to
6f61428
Compare
stof
approved these changes
May 26, 2020
wouterj
force-pushed
the
issue-36814/handle-logout-csrf-exception
branch
from
6f61428
to
69be9fe
Compare
wouterj
force-pushed
the
issue-36814/handle-logout-csrf-exception
branch
from
69be9fe
to
50348f2
Compare
chalasr
approved these changes
May 26, 2020
|
Thank you @wouterj. |
This was referenced May 31, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8 years ago, a typo was made while refactoring the
ExceptionListener, loosing this logic (46071f3). I think we should fix it.The
LogoutExceptionis a very generic name for something only used when the CSRF token is invalid. Should we match the exception message to make sure only this CSRF error is transformed into 403? I didn't yet do it because any usage ofLogoutExceptionwould have resulted in 500, which always is worse than 403.