Handle fetch mode deprecation of DBAL 2.11. #36987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/3.4-fetchmode-deprecation
branch
3 times, most recently
from
d761aec
to
812f2ba
Compare
fabpot
approved these changes
May 28, 2020
nicolas-grekas
approved these changes
May 28, 2020
|
There's a related failure on appveyor. |
We don't have |
|
appveyor runs without any, then with many extensions. |
|
add |
derrabus
force-pushed
the
improvement/3.4-fetchmode-deprecation
branch
from
812f2ba
to
0c1e254
Compare
derrabus
force-pushed
the
improvement/3.4-fetchmode-deprecation
branch
from
0c1e254
to
ed51855
Compare
chalasr
approved these changes
May 28, 2020
|
AppVeyor is happy now. The segfaulting php 8 Cache tests on Travis is hopefully unrealated. 😅 |
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Handle fetch mode deprecation of DBAL 2.11 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Continuation of #36987 on the 4.4 branch. Commits ------- 1385213 Handle fetch mode deprecation of DBAL 2.11.
This was referenced May 31, 2020
Merged
Merged
Merged
Merged
|
Things moved in DBAL v3 and tests are now failing after doctrine/dbal#4049 and/or doctrine/dbal#4045 |
|
Looks like part of the fix might be as simple as backporting #37141. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 9, 2020
…bbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] fix forward compatibility with Doctrine DBAL 3 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36987 (comment) | License | MIT | Doc PR | Commits ------- 316efef fix forward compatibility with Doctrine DBAL 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See doctrine/dbal#4019
DBAL has deprecated PDO-style fetch modes in favor of more explicit methods.