Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Apply ExpressionLanguageProviderPass to router.default #37044

Merged
merged 1 commit into from Jun 11, 2020

Conversation

wizhippo
Copy link
Contributor

@wizhippo wizhippo commented Jun 1, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37042
License MIT

Using a chain_router usually replaces the router and add the router.default to it's chain.

This would addExpressionLanguageProvider to the default router only as the chain router is not expected to have addExpressionLanguageProvider as it is not part of the router interface.

@fabpot
Copy link
Member

fabpot commented Jun 11, 2020

Thank you @wizhippo.

@fabpot fabpot merged commit faafec4 into symfony:5.1 Jun 11, 2020
@wizhippo wizhippo deleted the patch-1 branch June 11, 2020 14:05
@fabpot fabpot mentioned this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants