Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] fix monitoring timeouts when other streams are active #37048

Merged
merged 1 commit into from Jun 7, 2020
Merged

[HttpClient] fix monitoring timeouts when other streams are active #37048

merged 1 commit into from Jun 7, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jun 1, 2020
@nicolas-grekas nicolas-grekas force-pushed the hc-to+concurrency branch 2 times, most recently from efb3cbb to cc9762a Compare June 1, 2020 17:06
@fabpot
Copy link
Member

fabpot commented Jun 2, 2020

Tests are broken apparently.

@nicolas-grekas nicolas-grekas force-pushed the hc-to+concurrency branch 21 times, most recently from 827e8aa to a4c2ef2 Compare June 5, 2020 20:08
@nicolas-grekas
Copy link
Member Author

Now green.
CurlHttpClientTest::testTimeoutIsNotAFatalError() is skipped on Windows where it is too transient (for reasons unrelated to this PR.)

@nicolas-grekas nicolas-grekas merged commit 3755efd into symfony:4.4 Jun 7, 2020
@nicolas-grekas nicolas-grekas deleted the hc-to+concurrency branch June 11, 2020 13:32
This was referenced Jun 12, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolas-grekas @fabpot @carsonbot