Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray() #37065

Merged
merged 1 commit into from Jun 3, 2020
Merged

[HttpClient] Throw JsonException instead of TransportException on empty response in Response::toArray() #37065

merged 1 commit into from Jun 3, 2020

Conversation

jeroennoten
Copy link
Contributor

@jeroennoten jeroennoten commented Jun 2, 2020 •
edited

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37064
License MIT

@javiereguiluz
Copy link
Member

@jeroennoten thanks for this contribution! However, 4.3 branch is no longer maintained, so this should be submitted against 4.4 (see https://symfony.com/releases for the full details). Thanks.

@jeroennoten jeroennoten changed the base branch from 4.3 to 4.4 June 2, 2020 13:33
@jeroennoten jeroennoten force-pushed the throw-json-exception-on-empty-response-body-in-http-client-response-to-array branch from 897b21d to 81c74a3 Compare June 2, 2020 13:42
@jeroennoten
Copy link
Contributor Author

Hi @javiereguiluz, thanks for your feedback. I rebased to 4.4 and changed the target branch this pull request to 4.4.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jun 2, 2020
@jeroennoten jeroennoten force-pushed the throw-json-exception-on-empty-response-body-in-http-client-response-to-array branch from 81c74a3 to 69547d9 Compare June 2, 2020 13:48
@fabpot
Copy link
Member

fabpot commented Jun 3, 2020

Thank you @jeroennoten.

@fabpot fabpot merged commit fe61dd5 into symfony:4.4 Jun 3, 2020
This was referenced Jun 12, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeroennoten @javiereguiluz @fabpot @nicolas-grekas @yceruto @carsonbot