Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Move ajax clear event listener initialization on loadToolbar #37077

Merged
merged 1 commit into from Jun 2, 2020

Conversation

Seikyo
Copy link

@Seikyo Seikyo commented Jun 2, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37073
License MIT

Fix ajax clear event listener stacking on each ajax request made.
Comment says if should be synced with TwigBundle/Resources/views/base_js.html.twig

If not applicable feel free to deny.

@stof
Copy link
Member

stof commented Jun 2, 2020

This comment should be removed in the 5.0 branch of Symfony, as the base_js file from TwigBundle got removed there.

@stof
Copy link
Member

stof commented Jun 2, 2020

I'm quite sure this bugfix should apply to older versions than master though.

@Seikyo
Copy link
Author

Seikyo commented Jun 2, 2020

Sorry I'm a little lost in the process of proposing a pull request.
I checked the maintained versions from the roadmap and :

  • 3.4 is not applicable as it does not have event listener on '.sf-toolbar-ajax-clear'
  • 4.4 is applicable to this patch
  • 5.0 and 5.1 are applicable to this patch but top comment should be removed as you suggested

Should I update the pull request branch to ">=4.4" ?

@stof
Copy link
Member

stof commented Jun 2, 2020

yeah, please submit this to 4.4 (and then check if the TwigBundle file needs the same patch).

Removing the top comment in 5.0 is not actually something related to your bugfix (it is related to what you wrote, though). This should probably be done as a separate PR against the branch.

@Seikyo Seikyo force-pushed the fix_ajax_event_listeners_stacking branch from 4edfe93 to cf4587b Compare June 2, 2020 16:21
@Seikyo Seikyo requested a review from dunglas as a code owner June 2, 2020 16:21
@Seikyo Seikyo changed the base branch from master to 4.4 June 2, 2020 16:25
@Seikyo
Copy link
Author

Seikyo commented Jun 2, 2020

Pull request target was updated to origin/4.4 and rebased onto it.
No references to -clear were found in the TwigBundle/Resources/views/base_js.html.twig.

@fabpot
Copy link
Member

fabpot commented Jun 2, 2020

Thank you @Seikyo.

@fabpot fabpot merged commit 950ff7e into symfony:4.4 Jun 2, 2020
This was referenced Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web-profiler-bundle] Debug toolbar javascript stacks event listeners
4 participants