Routing Priority

[ad3n]

Symfony version(s) affected: 5.1

Description
Routing Priority doesn't support for controller with only have one method

How to reproduce

@Route("/abc/{id}")
in : XClassController::__invoke()

@Route("/abc/static-value-here", priority=7)
in: YClassController::__invoke()

[nicolas-grekas]

What does it mean? Does it break with an error? Which one?
If not, what else?

[ad3n]

@nicolas-grekas: When your controller only has one method and you setting up route priority and then you create other controller also has one method (default priority is 0)

The route priority mechanism is not work properly

[xabbuh]

What exactly does that mean? What route is matched for which request and which request did you expect to be matched instead?

[ad3n]

@xabbuh : when read the blog (https://symfony.com/blog/new-in-symfony-5-1-route-annotations-priority), route priority only work when your controller have two or greater method in controller

As i mention in example, i use __invoke method per controller and set up route priority because my YController route must has higher priority than XController

But that's not work as my expectation. The XController always has higher priority so YController never execute when route match /abc/static-value-here

[xabbuh]

I can confirm this.

Status: Reviewed

[xabbuh]

Looking at the implementation I think that's expected. The priority is only taken into account for the routes that are part of the same collection (i.e. are loaded from annotations of the same class).

/cc @nicolas-grekas

[nicolas-grekas]

I don't remember :) Priorities should be preserved when merging a subcollection into a bigger one. I think that's what the code in RouteCollection::addCollection() is doing(), isn't it?

[yceruto]

I can confirm this too, and I found the issue, working on it...

[yceruto]

It should be fixed in #37176

[ad3n]

@yceruto thank you so much for your awesome work 👍