[Form] switch the context when validating nested forms #37103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 4, 2020
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37072 |
| License | MIT |
| Doc PR |
This was referenced Jun 4, 2020
fabpot
added a commit
that referenced
this pull request
Jun 9, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Form] rework form validator tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This will allow writing tests for #37103. Commits ------- f062e08 rework form validator tests
|
this bug also in 5.0 and 5.1 |
|
tests added Status: Needs Review |
VincentLanglet
approved these changes
Jun 11, 2020
|
Tests look broken by this change. |
xabbuh
commented
Jun 12, 2020
| @@ -26,9 +26,10 @@ | |||
| }, | |||
| "require-dev": { | |||
| "doctrine/collections": "~1.0", | |||
| "symfony/validator": "^3.2.5|~4.0", | |||
| "symfony/validator": "^3.4.3|^4.0.3", | |||
There was a problem hiding this comment.
to get #25529 which prevents the deps=low build to fail
fabpot
approved these changes
Jun 12, 2020
|
Thank you @xabbuh. |
This was referenced Jun 12, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.