[SecurityBundle] Fix the session listener registration under the new authentication manager #37126
+48
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Jun 7, 2020
| @@ -60,10 +60,8 @@ | |||
| </service> | |||
|
|
|||
| <service id="security.listener.session" | |||
| class="Symfony\Component\Security\Http\EventListener\SessionStrategyListener" | |||
| abstract="true"> | |||
There was a problem hiding this comment.
this abstract="true" must be kept (the service itself should not be used, only the ones created based on this in the SecurityExtension)
johnvandeweghe
force-pushed
the
ticket_37119
branch
from
fdc7fd9
to
224e65a
Compare
fabpot
approved these changes
Jun 8, 2020
…authentication manager
|
Thank you @johnvandeweghe. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the logic that adds session listeners for firewalls to properly add them only for statefull firewalls. Adds tests to confirm that it is only added to statefull ones. Also remove unused abstract field on session listener