[PhpUnitBridge] Fix ExpectDeprecationTrait::expectDeprecation() conflict #37153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
php-unit-bridge-expect-deprecation-compat
branch
2 times, most recently
from
8911978
to
6b9d6c0
Compare
fancyweb
force-pushed
the
php-unit-bridge-expect-deprecation-compat
branch
from
6b9d6c0
to
1e61bde
Compare
fancyweb
commented
Jun 9, 2020
fancyweb
force-pushed
the
php-unit-bridge-expect-deprecation-compat
branch
from
1e61bde
to
ea5bb24
Compare
nicolas-grekas
approved these changes
Jun 9, 2020
phansys
approved these changes
Jun 10, 2020
fabpot
approved these changes
Jun 10, 2020
|
Thank you @fancyweb. |
Merged
xabbuh
added a commit
that referenced
this pull request
Sep 18, 2020
…ridge (xabbuh) This PR was merged into the 5.1 branch. Discussion ---------- [Validator] fix lowest allowed version for the PHPUnit bridge | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Fixes the `deps=low` build for the Validator component by only allowing versions of the PHPUnit bridge that contain #37153. Commits ------- fb7ee79 fix lowest allowed version for the PHPUnit bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpectDeprecationTrait::expectDeprecation() must be compatible with TestCase::expectDeprecation(). I'm personally against a renaming on our side because this name is the best.