Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait #37154

Merged
merged 1 commit into from Jun 9, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets #37123
License MIT
Doc PR -

Needs symfony/recipes#781

@fabpot
Copy link
Member

fabpot commented Jun 9, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit fbc9f1c into symfony:5.1 Jun 9, 2020
@nicolas-grekas nicolas-grekas deleted the fwb-no-env-secret branch June 11, 2020 13:32
@fabpot fabpot mentioned this pull request Jun 12, 2020
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jun 12, 2020

If you see this error when upgrading, the patch is below:

You have requested a non-existent parameter "kernel.secret". Did you mean this: "kernel.charset"?                                                       
--- a/config/packages/framework.yaml
+++ b/config/packages/framework.yaml
@@ -1,4 +1,5 @@
 framework:
+    secret: '%env(APP_SECRET)%'
     #csrf_protection: true
     #http_method_override: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants