[Mailer] Fixed generator bug when creating multiple transports using Transport::fromDsn #37159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atailouloute
commented
Jun 8, 2020
•
atailouloute
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | #37158 |
| License | MIT |
| Doc PR | N/A |
atailouloute
force-pushed
the
fix-bug-multiple-transport
branch
from
61eb7d7
to
5d9bc15
Compare
fabpot
requested changes
Jun 9, 2020
atailouloute
force-pushed
the
fix-bug-multiple-transport
branch
from
5d9bc15
to
bc0924c
Compare
…Transport::fromDsn
fabpot
force-pushed
the
fix-bug-multiple-transport
branch
from
bc0924c
to
c5833fa
Compare
fabpot
approved these changes
Jun 9, 2020
|
Thank you @atailouloute. |
This was referenced Jun 12, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.