Reset question validator attempts only for actual stdin #37160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 14, 2020
nicolas-grekas
force-pushed
the
issue-37046
branch
from
65bb24a
to
2994095
Compare
nicolas-grekas
force-pushed
the
issue-37046
branch
from
2994095
to
8fe7be4
Compare
chalasr
approved these changes
Jun 14, 2020
|
Thank you @ostrolucky. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 15, 2020
…l stdin (bis) (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Console] Reset question validator attempts only for actual stdin (bis) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - #37160 [fails](https://travis-ci.org/github/symfony/symfony/jobs/698492147), this should fix it by looking at the actual input stream. Commits ------- 867642e [Console] Reset question validator attempts only for actual stdin (bis)
Merged
weierophinney
added a commit
to weierophinney/laminas-cli
that referenced
this pull request
Jun 15, 2020
symfony/console 5.1.2 incorporates symfony/symfony#37160, which fixes symfony/symfony#37046, removing the need for the workarounds introduced in TypeHintedParamAwareInput. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what CI says. Works for me locally with phpunit and when running such command manually