[Routing] Keeping routes priorities after add a name prefix to the collection #37176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Jun 9, 2020
yceruto
commented
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37089 |
| License | MIT |
| Doc PR | - |
Closed
yceruto
commented
Jun 9, 2020
| @@ -179,8 +179,8 @@ public function addNamePrefix(string $prefix) | |||
|
|
|||
| foreach ($this->routes as $name => $route) { | |||
| $prefixedRoutes[$prefix.$name] = $route; | |||
| if (null !== $name = $route->getDefault('_canonical_route')) { | |||
| $route->setDefault('_canonical_route', $prefix.$name); | |||
| if (null !== $canonicalName = $route->getDefault('_canonical_route')) { | |||
nicolas-grekas
approved these changes
Jun 9, 2020
|
This is called here for instance: symfony/src/Symfony/Component/Routing/Loader/YamlFileLoader.php Lines 217 to 219 in 6d6d989 even if the name prefix is not defined, due to: I wonder if we should compare with empty string instead or change to |
xabbuh
approved these changes
Jun 9, 2020
|
@yceruto that'd make sense yes |
yceruto
commented
Jun 9, 2020
| @@ -171,7 +171,7 @@ protected function parseImport(RouteCollection $collection, array $config, strin | |||
| $schemes = isset($config['schemes']) ? $config['schemes'] : null; | |||
| $methods = isset($config['methods']) ? $config['methods'] : null; | |||
| $trailingSlashOnRoot = $config['trailing_slash_on_root'] ?? true; | |||
| $namePrefix = $config['name_prefix'] ?? ''; | |||
| $namePrefix = $config['name_prefix'] ?? null; | |||
There was a problem hiding this comment.
consistent with Xml loader:
Tobion
reviewed
Jun 9, 2020
yceruto
force-pushed
the
route_priority_with_prefix
branch
from
2a294fe
to
1010526
Compare
Tobion
approved these changes
Jun 10, 2020
fabpot
approved these changes
Jun 10, 2020
|
Thank you @yceruto. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.