Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lock] remove non-standard MongoDbStore URI parameters before passing to driver #37180

Closed
kralos opened this issue Jun 10, 2020 · 0 comments · Fixed by #37218
Closed

[Lock] remove non-standard MongoDbStore URI parameters before passing to driver #37180

kralos opened this issue Jun 10, 2020 · 0 comments · Fixed by #37218
Labels
Bug Lock Status: Needs Review

Comments

@kralos
Copy link

kralos commented Jun 10, 2020 •
edited

Symfony version(s) affected: 5.1.0

Description
@jmikola has raised concerns with our handling of both the database path and collection query string in a MongoDbStore constructed with a MongoDB connection URI. Please see #37140 (comment)

How to reproduce
Construction of a MongoDbStore using a MongoDB connection URI with collection= in the querystring.

Possible Solution
We should remove collection from the query string before passing the URI to the driver.

Additional context
#37140 (comment)

See the note regarding libmongoc client and connection re-use internally: https://www.php.net/manual/en/mongodb.connection-handling.php
@kralos kralos added the Bug label Jun 10, 2020
@kralos kralos mentioned this issue Jun 10, 2020
Merged
@xabbuh xabbuh added the Lock label Jun 10, 2020
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 deprecated extracting default database or collection fr…
1caf226 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 updated UPGRADE and CHANGELOG
14939ea
@kralos kralos mentioned this issue Jun 10, 2020
Closed
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 coding standards fixes for fabbot
6e52238
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 added deprecation tests
46daa18
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 fixed MongoDbStoreTest
b166938
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 added deprecation contracts to lock component
b617f3c
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 fixed construction providers
d85d4e8
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 fixed deprecations tests
01149d0
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 deprecated extracting default database or collection fr…
4aebca6 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 deprecated extracting default database or collection fr…
845adfb 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 don't deprecate before throwing InvalidArgumentException
b6e06a6
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 removed credentials as test db doesn't have users
2e86c22
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 deprecated extracting default database or collection fr…
9d4f332 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 10, 2020
symfony#37180 deprecated extracting default database or collection fr…
6fa11e6 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 11, 2020
symfony#37180 deprecated extracting default database or collection fr…
74ac915 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 11, 2020
symfony#37180 deprecated extracting default database or collection fr…
fd508ab 
…om MongoDB connection URI
kralos pushed a commit to kralos/symfony that referenced this issue Jun 11, 2020
symfony#37180 skim non-standard options from connection uri into options
78ca910
@kralos kralos mentioned this issue Jun 11, 2020
Merged
kralos pushed a commit to kralos/symfony that referenced this issue Jun 11, 2020
symfony#37180 cs for fabbot
abc02f8
kralos pushed a commit to kralos/symfony that referenced this issue Jun 11, 2020
symfony#37180 cs for fabbot
f10d7ad
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 swapped uri / options precedence
2dc281b
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 skim non-standard options from connection uri into options
558f9cc
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 cs for fabbot
a2f4503
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 cs for fabbot
798ffa2
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 swapped uri / options precedence
992649d
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 Added collection and database option precedence tests
eb8fe01
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 don't pass collection query parameter to driver, dsn sh…
89f879e 
…ould take precedence over options
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 Added test for stripping collection from dsn
e8c54dd
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 fixed testDatabaseDsnPrecedence
e06956a
kralos pushed a commit to kralos/symfony that referenced this issue Jun 15, 2020
symfony#37180 don't pass collection query parameter to driver, dsn sh…
599c128 
…ould take precedence over options
kralos pushed a commit to kralos/symfony that referenced this issue Jun 16, 2020
symfony#37180 improved uri test
45e349d
kralos pushed a commit to kralos/symfony that referenced this issue Jun 16, 2020
symfony#37180 added collection strip test
47786e7
kralos pushed a commit to kralos/symfony that referenced this issue Jun 16, 2020
symfony#37180 fixed fabbot cs
4df26a9
kralos pushed a commit to kralos/symfony that referenced this issue Jun 18, 2020
symfony#37180 don't pass collection query parameter to driver
523bf2a
@kralos kralos changed the title [Lock] deprecate non-standard usage of database and collection in MongoDbStore URI [Lock] remove non-standard MongoDbStore URI parameters before passing to driver Jun 18, 2020
kralos pushed a commit to kralos/symfony that referenced this issue Jun 22, 2020
symfony#37180 fixed unreferenced var in exception
a5770aa
kralos pushed a commit to kralos/symfony that referenced this issue Jun 22, 2020
symfony#37180 improved skimUri documentation
79fee70
@fabpot fabpot closed this as completed Aug 16, 2020
fabpot added a commit that referenced this issue Aug 16, 2020
@fabpot
bug #37218 [Lock] MongoDbStore skim non-standard options from uri (kr…
5f074cd 
…alos)

This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Lock] MongoDbStore skim non-standard options from uri

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37180
| License       | MIT
| Doc PR        |

Don't allow non-standard connection uri options reach `MongoDB\Client`

Commits
-------

67912fa [Lock] MongoDbStore skim non-standard options from uri
@jmikola jmikola mentioned this issue Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Lock Status: Needs Review
Projects
None yet
Milestone
No milestone
4 participants
@fabpot @kralos @xabbuh @carsonbot