[SecurityBundle] Fix CookieClearingLogoutListener DI configuration #37283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Jun 15, 2020
wouterj
commented
| Q | A |
|---|---|
| Branch? | 5.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37282 |
| License | MIT |
| Doc PR | - |
chalasr
approved these changes
Jun 15, 2020
|
Please do not merge yet, I need to update the test to see if the cookie is deleted. I'm struggling quite hard to achieve that |
wouterj
changed the title
wouterj
changed the title
wouterj
force-pushed
the
issue-37282/fix-logout-subscriber
branch
from
e3e1080
to
4786988
Compare
|
Test fixed, can be merged :) |
|
Thank you @wouterj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.