[Console] Reset question validator attempts only for actual stdin (bis) #37286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jun 15, 2020
| if (!\defined('STDIN')) { | ||
| $inputStream = $this->inputStream ?: fopen('php://stdin', 'r'); | ||
|
|
||
| if ('php://stdin' !== (stream_get_meta_data($inputStream)['url'] ?? null)) { |
There was a problem hiding this comment.
actually this is not needed to fix the failure, but making the behavior of this method global looks suspicious to me so here is a local check
There was a problem hiding this comment.
note that this check works even if $inputStream === STDIN
There was a problem hiding this comment.
Are you sure with url here?
>>> stream_get_meta_data(STDIN)['url']
PHP Notice: Undefined index: url in phar://eval()'d code on line 1
=> null
>>> stream_get_meta_data(STDIN)
=> [
"timed_out" => false,
"blocked" => true,
"eof" => false,
"wrapper_type" => "PHP",
"stream_type" => "STDIO",
"mode" => "rb",
"unread_bytes" => 0,
"seekable" => false,
"uri" => "php://stdin",
]
There was a problem hiding this comment.
Pretty much yes: https://3v4l.org/njZZV
What's your runtime?
There was a problem hiding this comment.
That 3v4l snippet follows behaviour I observe on my PC, it looks to be uri, not url
| return true; | ||
| } | ||
|
|
||
| if (\function_exists('stream_isatty')) { | ||
| return stream_isatty(fopen('php://input', 'r')); | ||
| return stream_isatty($inputStream); |
There was a problem hiding this comment.
this was my mistake: using php://stdin here instead is enough to fix the failure
nicolas-grekas
force-pushed
the
console-stdin
branch
from
0aff5d8
to
8069160
Compare
nicolas-grekas
force-pushed
the
console-stdin
branch
from
8069160
to
867642e
Compare
chalasr
approved these changes
Jun 15, 2020
weaverryan
added a commit
to symfony/maker-bundle
that referenced
this pull request
Jul 6, 2020
… (weaverryan) This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- using stable-dev in tests to get latest fixes from Symfony This avoids a behavior change in symfony/console@6f533d9...d2c9f77 from symfony/symfony#37286 I'll create a PR to revert this after merge, which we will merge once the issue is resolved. Commits ------- 1309c01 updating test in one other spot ccfd248 forcing stable ORM in tests 6b512b8 making migration test work in all versions b5a5a11 phpcs 6af124a Guaranteeing that dev versions will get dev dependencies fd89d5d Forcing "stable" for 7.1 73f9ecc updating test for new version of migrations 0334718 Using stable-dev as default version in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37160 fails, this should fix it by looking at the actual input stream.