[Messenger] [Redis] Fixed problem where worker stops handling messages on first empty message

[jvmanji]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #48166
License	MIT
Doc PR	n/a

Fixed problem where worker stops handling messages on first empty message.

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[OskarStark]

Please associate your commiter email with your Github account

[nicolas-grekas]

I've rebased + squashed your PR to have a clean git history. Don't forget to fetch before working again on the patch if needed.
About the patch itself, I don't know the topic well enough. Anyone else willing to review in depth?

[chalasr]

Will do yes. Ping @alexander-schranz also since you provided some guidance in the linked issue (no hurry)

[Gregory-Gerard]

Is there anything I (or anyone else) can do to help with this PR?

I'm having the same problem, and this problem is also present in case of an invalid message (can't decode a JSON for example), it should never happen but I have an external system that can push in a stream read by Symfony Messenger, so it would be better if the transport to expect the possibility of an invalid or empty message and rejects this message.

[tourze]

Same problem, any update?

[nicolas-grekas]

I updated the PR to use reject.

[nicolas-grekas]

Thank you @jvmanji.