[Console] Fix the usage of the zsh completion through the fpath discovery #50110
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsh completion files registered through the fpath discovery mecanism have 2 requirements: - the file name must have a `_` prefix - the file must start with a `#compdef` comment describing the registration for that file. The file can then either execute the completion logic directly or call `compdef` to register a function for completion. Keeping the second approach allows to use the same generated script for the global use case than for a sourced configuration script.
chalasr
approved these changes
Apr 22, 2023
fabpot
approved these changes
Apr 22, 2023
|
Thank you @stof. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zsh completion files registered through the fpath discovery mecanism have 2 requirements:
_prefix#compdefcomment describing the registration for that file.The file can then either execute the completion logic directly or call
compdefto register a function for completion. Keeping the second approach allows to use the same generated script for the global use case than for a sourced configuration script.