[Serializer] backed enum throw notNormalizableValueException outside construct method #50192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alli83
force-pushed
the
serializer-backedEnum-throw-not-normalizable-value-exception-outside-construct-method
branch
2 times, most recently
from
897da96
to
53fd29d
Compare
TerjeBr
suggested changes
May 2, 2023
src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php
Outdated
Show resolved
Hide resolved
carsonbot
changed the title
nicolas-grekas
changed the title
…n a backedEnum in construct method
alli83
force-pushed
the
serializer-backedEnum-throw-not-normalizable-value-exception-outside-construct-method
branch
from
53fd29d
to
5549493
Compare
chalasr
approved these changes
May 3, 2023
fabpot
approved these changes
May 5, 2023
|
Thank you @alli83. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #47128 (comment) was aiming to throw an InvalidArgumentException if a constructor's argument is not a valid backedEnum( knowing an error will be thrown in all case e.g when it will be instantiated).
This PR aims to throw a NotNormalizableValueException (like it was the case before) if an error occurs on an BackedEnum outside the case of the first PR
So we have two different types of exceptions depending on whether it's an error at the constructor level or not.