Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ErrorHandler] Prevent conflicts with WebProfilerBundle’s JavaScript #50213

Merged
merged 1 commit into from May 5, 2023

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented May 2, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50108
License MIT
Doc PR N/A

ErrorHandler’s exception.js and WebProfilerBundle’s base_js.html.twig both expose a global Sfjs variable, which create conflicts (see linked issue e.g.).

As the exception page

  • does not make use of Sfjs
  • is not extensible

I updated exception.js to not create any global scope variable. I also removed DOMContentLoaded listeners as the script is run inline at the end of the document.

This PR stems from #48037.
Hiding whitespaces will produce a much more readable diff.

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks!

@fabpot
Copy link
Member

fabpot commented May 5, 2023

Thank you @MatTheCat.

@fabpot fabpot merged commit cd158aa into symfony:5.4 May 5, 2023
10 of 11 checks passed
@MatTheCat MatTheCat deleted the ticket_50108 branch May 5, 2023 11:44
@fabpot fabpot mentioned this pull request May 7, 2023
This was referenced May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants