[ErrorHandler] Prevent conflicts with WebProfilerBundle’s JavaScript #50213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorHandler’s
exception.js
and WebProfilerBundle’sbase_js.html.twig
both expose a globalSfjs
variable, which create conflicts (see linked issue e.g.).As the exception page
Sfjs
I updated
exception.js
to not create any global scope variable. I also removedDOMContentLoaded
listeners as the script is run inline at the end of the document.This PR stems from #48037.
Hiding whitespaces will produce a much more readable diff.