Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Fix getting through proxies via CONNECT #50235

Merged
merged 1 commit into from May 5, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted while trying to hit google via symfony proxy:start:

https_proxy=http://127.0.0.1:7080 php test.php

where test.php contains:

$client = new CurlHttpClient();

$r = $client->request('GET', 'https://google.com/');

dump($r->getStatusCode());
dump($r->getHeaders());
dump($r->getInfo('debug'));

@stof
Copy link
Member

stof commented May 4, 2023

is there any way to have a test covering this to prevent regressions ?

@nicolas-grekas
Copy link
Member Author

I won't be able to add a test covering that because it requires an HTTPS endpoint. Of course we could add some network services, but that's going to be too time consuming to setup properly...

@nicolas-grekas
Copy link
Member Author

Of course, I would gladly accept a PR that adds the test if anyone reading is up to give it a try!

@nicolas-grekas nicolas-grekas merged commit d038a0e into symfony:5.4 May 5, 2023
9 of 11 checks passed
@nicolas-grekas nicolas-grekas deleted the hc-proxy branch May 5, 2023 15:49
@fabpot fabpot mentioned this pull request May 7, 2023
This was referenced May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants