[HttpKernel] Prevent initialising lazy services during services reset #50241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one happens to have a service that is configured to be lazy AND also implements
ResetInterface
, when Symfony resets resettableService, it will callreset
on the service which will trigger the initialization even though the service has not been actually used by the code, which defeats the purpose of having the service lazy.To fix this I propose to skip resetting a service that is marked as
LazyObjectInterface
and has not been initialized (ie not used yet)