Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dotenv] Allow environment variables starting with an underscore #52928

Merged
merged 1 commit into from
Dec 28, 2023
Merged

[Dotenv] Allow environment variables starting with an underscore #52928

merged 1 commit into from
Dec 28, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 7, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52630
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Dec 7, 2023
@OskarStark OskarStark changed the title [Dotenv] allow environment variables starting with an underscore [Dotenv] Allow environment variables starting with an underscore Dec 8, 2023
@OskarStark
Copy link
Contributor

This sounds like a new feature to me

fabpot
fabpot requested changes Dec 8, 2023
View reviewed changes
src/Symfony/Component/Dotenv/Dotenv.php Outdated Show resolved Hide resolved
derrabus
derrabus approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Following @fabpot's remark, shall we add a test to make sure _ is not a valid env var?

@OskarStark
Copy link
Contributor

There is a test already

@fabpot
Copy link
Member

fabpot commented Dec 28, 2023

Thank you @xabbuh.

@fabpot fabpot merged commit d9ce166 into symfony:5.4 Dec 28, 2023
8 of 11 checks passed
@xabbuh xabbuh deleted the issue-52630 branch December 28, 2023 18:13
This was referenced Dec 30, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Dotenv Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xabbuh @OskarStark @fabpot @derrabus @carsonbot