Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow recipes to work with php config files (instead of default yaml) #54090

Closed
arderyp opened this issue Feb 27, 2024 · 4 comments
Closed

allow recipes to work with php config files (instead of default yaml) #54090

arderyp opened this issue Feb 27, 2024 · 4 comments

Comments

@arderyp
Copy link
Contributor

arderyp commented Feb 27, 2024

Description

I've recently migrated from yaml config files to PHP config files due to compelling arguments by @TomasVotruba: https://getrector.com/blog/modernize-symfony-configs

one consequence is that updating recipes seems to write yaml config files only (or am I missing something?). It owuld be helpful if we could configure it to work with systems using PHP configs.

Example

No response

@k0d3r1s
Copy link
Contributor

k0d3r1s commented Feb 28, 2024

this looks like flex thing: https://github.com/symfony/flex
biggest problem here is to copy right config from recipe, adding .php config to recipe seems already doable. adding both .yaml and .php now would copy both files to project

@stof
Copy link
Member

stof commented Feb 28, 2024

We don't maintain 2 variants of each recipe to use either Yaml or PHP config files. So if you want to rely on the Flex recipes, you need to stick to Yaml for now.

@xabbuh
Copy link
Member

xabbuh commented Feb 28, 2024

let's close here in favor of symfony/flex#970

@xabbuh xabbuh closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
@arderyp
Copy link
Contributor Author

arderyp commented Feb 29, 2024

Thanks for the confirmation and the link to the other issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants