From 78d6c6ef5b3e07ab90a0e64e65de1f1ea2e814f5 Mon Sep 17 00:00:00 2001 From: Filippo Tessarotto Date: Mon, 27 Apr 2020 08:33:58 +0200 Subject: [PATCH] [BrowserKit] Allow Referer set by history to be overridden --- src/Symfony/Component/BrowserKit/AbstractBrowser.php | 2 +- .../Component/BrowserKit/Tests/AbstractBrowserTest.php | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php index dbd6051c8fd5..209d04821476 100644 --- a/src/Symfony/Component/BrowserKit/AbstractBrowser.php +++ b/src/Symfony/Component/BrowserKit/AbstractBrowser.php @@ -366,7 +366,7 @@ public function request(string $method, string $uri, array $parameters = [], arr $uri = preg_replace('{^'.parse_url($uri, PHP_URL_SCHEME).'}', $server['HTTPS'] ? 'https' : 'http', $uri); } - if (!$this->history->isEmpty()) { + if (!isset($server['HTTP_REFERER']) && !$this->history->isEmpty()) { $server['HTTP_REFERER'] = $this->history->current()->getUri(); } diff --git a/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php b/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php index e0e3fb2ca8f2..1ee9562ceb14 100644 --- a/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php +++ b/src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php @@ -215,6 +215,15 @@ public function testRequestReferer() $this->assertEquals('http://www.example.com/foo/foobar', $server['HTTP_REFERER'], '->request() sets the referer'); } + public function testRequestRefererCanBeOverridden() + { + $client = $this->getBrowser(); + $client->request('GET', 'http://www.example.com/foo/foobar'); + $client->request('GET', 'bar', [], [], ['HTTP_REFERER' => 'xyz']); + $server = $client->getRequest()->getServer(); + $this->assertEquals('xyz', $server['HTTP_REFERER'], '->request() allows referer to be overridden'); + } + public function testRequestHistory() { $client = $this->getBrowser();