Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/var-dumper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.6
Choose a base ref
...
head repository: symfony/var-dumper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.3.7
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 4, 2021

  1. Copy the full SHA
    7f65c44 View commit details
  2. Merge branch '4.4' into 5.3

    * 4.4:
      Fix return types for PHP 8.1
    derrabus committed Aug 4, 2021

    Verified

    This commit was signed with the committer’s verified signature.
    targos Michaël Zasso
    Copy the full SHA
    0ec424e View commit details
  3. Fix return types for PHP 8.1

    Signed-off-by: Alexander M. Turek <me@derrabus.de>
    derrabus committed Aug 4, 2021

    Verified

    This commit was signed with the committer’s verified signature.
    targos Michaël Zasso
    Copy the full SHA
    3ad5af4 View commit details
Showing with 7 additions and 1 deletion.
  1. +6 −0 Cloner/Data.php
  2. +1 −1 Tests/Caster/CasterTest.php
6 changes: 6 additions & 0 deletions Cloner/Data.php
Original file line number Diff line number Diff line change
@@ -111,6 +111,7 @@ public function getValue($recursive = false)
/**
* @return int
*/
#[\ReturnTypeWillChange]
public function count()
{
return \count($this->getValue());
@@ -119,6 +120,7 @@ public function count()
/**
* @return \Traversable
*/
#[\ReturnTypeWillChange]
public function getIterator()
{
if (!\is_array($value = $this->getValue())) {
@@ -150,6 +152,7 @@ public function __isset(string $key)
/**
* @return bool
*/
#[\ReturnTypeWillChange]
public function offsetExists($key)
{
return $this->__isset($key);
@@ -158,6 +161,7 @@ public function offsetExists($key)
/**
* @return mixed
*/
#[\ReturnTypeWillChange]
public function offsetGet($key)
{
return $this->__get($key);
@@ -166,6 +170,7 @@ public function offsetGet($key)
/**
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetSet($key, $value)
{
throw new \BadMethodCallException(self::class.' objects are immutable.');
@@ -174,6 +179,7 @@ public function offsetSet($key, $value)
/**
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetUnset($key)
{
throw new \BadMethodCallException(self::class.' objects are immutable.');
2 changes: 1 addition & 1 deletion Tests/Caster/CasterTest.php
Original file line number Diff line number Diff line change
@@ -164,7 +164,7 @@ public function testAnonymousClass()
, $c
);

$c = eval('return new class implements \Countable { private $foo = "foo"; public function count() { return 0; } };');
$c = eval('return new class implements \Countable { private $foo = "foo"; public function count(): int { return 0; } };');

$this->assertDumpMatchesFormat(
<<<'EOTXT'