-
-
Notifications
You must be signed in to change notification settings - Fork 130
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/yaml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.13
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/yaml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.14
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 6 files changed
- 7 contributors
Commits on Sep 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c2162b5 - Browse repository at this point
Copy the full SHA c2162b5View commit details -
* 3.4: Enable "native_constant_invocation" CS rule Make AbstractPhpFileCacheWarmer public
Configuration menu - View commit details
-
Copy full SHA for 4b9c6dc - Browse repository at this point
Copy the full SHA 4b9c6dcView commit details
Commits on Sep 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 96800ef - Browse repository at this point
Copy the full SHA 96800efView commit details
Commits on Sep 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b7d9b4a - Browse repository at this point
Copy the full SHA b7d9b4aView commit details
Commits on Sep 8, 2020
-
* 3.4: Prevent parsing invalid octal digits as octal numbers [DI] fix ContainerBuilder on PHP8 [Console] Make sure $maxAttempts is an int or null. [VarDumper] Fix caster for invalid SplFileInfo objects on php 8. [Intl] Skip test cases that produce a TypeError on php 8. [PhpUnitBridge] Adjust output parsing for PHPUnit 9.3. [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x add bosnian (bs) translation [Debug] Parse "x not found" errors correctly on php 8.
Configuration menu - View commit details
-
Copy full SHA for defb343 - Browse repository at this point
Copy the full SHA defb343View commit details
Commits on Sep 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e6f16d8 - Browse repository at this point
Copy the full SHA e6f16d8View commit details
Commits on Sep 17, 2020
-
* 3.4: remove superfluous cast Change 'cache_key' to AbstractRendererEngine::CACHE_KEY_VAR Upgrade PHPUnit to 8.5 (php 7.2) and 9.3 (php >= 7.3).
Configuration menu - View commit details
-
Copy full SHA for e53b8b6 - Browse repository at this point
Copy the full SHA e53b8b6View commit details
Commits on Sep 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 50f080d - Browse repository at this point
Copy the full SHA 50f080dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6d162b - Browse repository at this point
Copy the full SHA c6d162bView commit details -
bug #38228 [Yaml Parser] Fix edge cases when parsing multiple documen…
…ts (digilist) This PR was merged into the 3.4 branch. Discussion ---------- [Yaml Parser] Fix edge cases when parsing multiple documents | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | I identified some edge cases when parsing multiple YAML documents with the same parser instance, because the totalNumberOfLines was not reset and so any subsequent parsing considered the number of lines of the first document. Consider this document: ```yaml a: b: | row row2 c: d ``` Normally, `a.b` would be parsed as `row\nrow2\n`. But if the parser parsed a shorter document before, the `\n` after row2 was missing, as the parser considered it as the end of the file (that's why the `c: d` at the end is important). So this fix resets the `totalNumberOfLines` in the YAML parser to `null` so that any subsequent parsing will initialize the value for the new document and does not use the file length of the first parsed document. I stumbled upon this because of a flickering unit test that was using the translation component. Sometimes the translated string contained a trailing `\n` and sometimes not. In the end it was based on this bug, as the translation files were not loaded in the same order every time (not really sure why. It's somehow related to the cache state, but even with a warm cache it was not totally deterministic). Commits ------- 012ee4fa59 [Yaml Parser] Fix edge cases when parsing multiple documents
Configuration menu - View commit details
-
Copy full SHA for a2b5a78 - Browse repository at this point
Copy the full SHA a2b5a78View commit details -
* 3.4: drop logger mock in favor of using the BufferingLogger [Yaml Parser] Fix edge cases when parsing multiple documents fix parsing comments not prefixed by a space
Configuration menu - View commit details
-
Copy full SHA for 55f2c00 - Browse repository at this point
Copy the full SHA 55f2c00View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec3c2ac - Browse repository at this point
Copy the full SHA ec3c2acView commit details
Commits on Sep 27, 2020
-
* 3.4: update missing translations arabic [Yaml] simplify the test fix test by letting mock throw the actual expected exception
Configuration menu - View commit details
-
Copy full SHA for c788596 - Browse repository at this point
Copy the full SHA c788596View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.4.13...v4.4.14