Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/yaml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.26
Choose a base ref
...
head repository: symfony/yaml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.27
Choose a head ref
  • 6 commits
  • 6 files changed
  • 5 contributors

Commits on Jun 30, 2021

  1. CS fixes

    nicolas-grekas committed Jun 30, 2021
    Copy the full SHA
    8e3c2dd View commit details

Commits on Jul 12, 2021

  1. Fix ctype_digit deprecation

    alexpott committed Jul 12, 2021
    Copy the full SHA
    099377a View commit details

Commits on Jul 13, 2021

  1. Copy the full SHA
    6d747d1 View commit details
  2. bug #42074 Fix ctype_digit deprecation (alexpott)

    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    Fix ctype_digit deprecation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Running the Yaml unit tests on PHP 8.1 built: Jul 12 2021 00:22:13 results in the following PHP Notices:
    ```
    Testing /Users/alex/dev/symfony/src/Symfony/Component/Yaml/Tests
    ...............................................................  63 / 689 (  9%)
    ............................................................... 126 / 689 ( 18%)
    ............................................................... 189 / 689 ( 27%)
    ............................................................... 252 / 689 ( 36%)
    ............................................................... 315 / 689 ( 45%)
    ............................................................... 378 / 689 ( 54%)
    ............................................................... 441 / 689 ( 64%)
    ............................................................... 504 / 689 ( 73%)
    ............................................................... 567 / 689 ( 82%)
    ............................................................... 630 / 689 ( 91%)
    ...........................................................     689 / 689 (100%)
    
    Time: 00:00.336, Memory: 20.00 MB
    
    OK (689 tests, 984 assertions)
    
    Unsilenced deprecation notices (131)
    
      109x: ctype_digit(): Argument of type int will be interpreted as string in the future
        53x in DumperTest::testSpecifications from Symfony\Component\Yaml\Tests
        21x in DumperTest::testInlineLevel from Symfony\Component\Yaml\Tests
        16x in InlineTest::testDump from Symfony\Component\Yaml\Tests
        7x in DumperTest::testDumpingArrayObjectInstancesWithNumericKeysInlined from Symfony\Component\Yaml\Tests
        7x in DumperTest::testDumpingArrayObjectInstancesWithNumericKeysRespectsInlineLevel from Symfony\Component\Yaml\Tests
        3x in DumperTest::testIndentationInConstructor from Symfony\Component\Yaml\Tests
        1x in DumperTest::testObjectSupportEnabled from Symfony\Component\Yaml\Tests
        1x in DumperTest::testObjectSupportDisabledButNoExceptions from Symfony\Component\Yaml\Tests
    
      22x: ctype_digit(): Argument of type float will be interpreted as string in the future
        15x in DumperTest::testSpecifications from Symfony\Component\Yaml\Tests
        6x in InlineTest::testDump from Symfony\Component\Yaml\Tests
        1x in InlineTest::testDumpNumericValueWithLocale from Symfony\Component\Yaml\Tests
    ```
    
    Commits
    -------
    
    5c57324117 Fix ctype_digit deprecation
    nicolas-grekas committed Jul 13, 2021
    Copy the full SHA
    d5a2222 View commit details

Commits on Jul 21, 2021

  1. Leverage str_ends_with

    added the php80 polyfill to requirements when necessary
    Tobion committed Jul 21, 2021
    Copy the full SHA
    54262b5 View commit details
  2. Leverage str_contains/str_starts_with

    Signed-off-by: Alexander M. Turek <me@derrabus.de>
    derrabus authored and nicolas-grekas committed Jul 21, 2021
    Copy the full SHA
    2b5f2ae View commit details
Loading