Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle creation is broken in 2.7 #2920

Open
michael-e opened this issue Jul 23, 2020 · 4 comments
Open

Handle creation is broken in 2.7 #2920

michael-e opened this issue Jul 23, 2020 · 4 comments

Comments

@michael-e
Copy link
Member

michael-e commented Jul 23, 2020

Affected Symphony version(s) : 2.7.x
PHP version(s) : all

Handle creation in Symphony 2.7 is broken. +characters, for example, will be included in handles, but they should not be. You can even break datasource filtering (by handles) if you include +++ in a string.

#2887 escaped literal hyphens in character classes in order to prevent errors in PHP 7.3+. Unfortunatley, one of the fixes (in General::createHandle) was erroneous, because the hyphen in question was not meant to be a literal hyphen (but part of a character range instead).

I willl send a pull request.

@cylkee
Copy link
Contributor

cylkee commented Jul 23, 2020

See also #2907

@animaux
Copy link
Contributor

animaux commented Aug 25, 2020

@michael-e your PR sadly did not help with my particular problem of untransliterated |-characters in handles. Using the preg-expression from 3.0.0 seems to do the trick.* @nitriques would probably know if this has other side effects.

* in line 347 changing to preg_match_all('/[\p{L}\w:;.,+=~]+/u', $string, $matches); from 9c43772

@michael-e
Copy link
Member Author

your PR sadly did not help with my particular problem of untransliterated |-characters

Well, it was not intended to do so. In other words: This is a different issue.

@animaux
Copy link
Contributor

animaux commented Aug 25, 2020

your PR sadly did not help with my particular problem of untransliterated |-characters

Well, it was not intended to do so. In other words: This is a different issue.

OK, I see. I was hoping defining a transliterarion for | in the lang_german-extension would help, but it did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants