Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications new shared folder and new peered device #52

Open
xor-gate opened this issue Jul 3, 2018 · 4 comments
Open

Notifications new shared folder and new peered device #52

xor-gate opened this issue Jul 3, 2018 · 4 comments
Labels
enhancement help wanted
Milestone
Unplanned (contri...

Comments

@xor-gate
Copy link
Member

xor-gate commented Jul 3, 2018 •
edited

Notifications where user intervention is necessary should be implemented for the following cases:

  • A new folder is shared
  • A new device is peered

Enhancement is based on: https://forum.syncthing.net/t/syncthing-for-macos/2745/22
@xor-gate xor-gate changed the title Notifications for use intervention Notifications new shared folder and new peered device Jul 3, 2018
xor-gate added a commit that referenced this issue Jul 3, 2018
@xor-gate
Initial work which fixes #52
74fc8a6
@xor-gate xor-gate mentioned this issue Jul 3, 2018
Closed
@xor-gate
Copy link
Member Author

xor-gate commented Jul 3, 2018

Initial prototype is functional to translate events to OS X notifications:

screen shot 2018-07-04 at 00 11 42

@xor-gate
Copy link
Member Author

xor-gate commented Jul 7, 2018

Had some discussion on the official forum about event behaviour in the webgui:

https://forum.syncthing.net/t/unexpected-continuous-devicereject-events-from-the-api-with-incrementing-ids

@xor-gate
Copy link
Member Author

xor-gate commented Jul 10, 2018 •
edited

We should keep issue syncthing/syncthing-android#679, and syncthing/syncthing#4084 in mind when implementing this.

@xor-gate
Copy link
Member Author

xor-gate commented Nov 7, 2018

Since v0.14.51 the new API is available so probably we should reimplement my work from branch https://github.com/syncthing/syncthing-macos/tree/feature/issue-52 into Swift.

@xor-gate xor-gate mentioned this issue Dec 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
Unplanned (contributions welcome)
Development

No branches or pull requests
1 participant
@xor-gate