Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 403 error from Robot API when API credentials are wrong #1262

Open
janiskemper opened this issue Apr 10, 2024 · 0 comments
Open

Handle 403 error from Robot API when API credentials are wrong #1262

janiskemper opened this issue Apr 10, 2024 · 0 comments
Assignees

Comments

@janiskemper
Copy link
Contributor

/kind bug

What steps did you take and what happened:
Start a system with bare metal servers and put a wrong robot password. This will trigger 403 errors from the Hetzner robot API. These errors are currently handled as "rate limit error", because they occur as well when a rate limit is lifted. This sounds weird but actually has to be done that way because we used to run into rate limits again, because 403 occurred right after the rate limit was lifted, and then we were again in a rate limit.

Right now we have a different 403 error that actually comes from wrong credentials. This should not be handled under the flag of "rate limits".

What did you expect to happen:
We should just requeue after some time if a 403 error occurs and write an error message that the credentials might be wrong. This is weird in the case that is described earlier that is related to a rate limit that occurred but is not too bad. However, it will be essential for people that actually put the wrong credentials to realize that this is the cause of the error they face.

@janiskemper janiskemper self-assigned this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant