Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should top/bottom/left/right refer to space theme values? #7

Open
daniellizik opened this issue Oct 17, 2019 · 1 comment
Open

Should top/bottom/left/right refer to space theme values? #7

daniellizik opened this issue Oct 17, 2019 · 1 comment

Comments

@daniellizik
Copy link

daniellizik commented Oct 17, 2019

Seems like absolutely positioned components are ignoring the values set in space. Is this by design (nothing in the docs)? What is the idiomatic way to write this?

styled.div`
  position: aboslute;
  left: 0; // not css value 0, but 0 index in the theme.space array
  bottom: 0;
`;

Position is an excluded value, I can see why, but I'd like to be able to set the coordinates based on themed space values

@jxnblk
Copy link
Member

jxnblk commented Oct 17, 2019

Position properties have never used theme.space in Styled System (you can use margin instead), which is probably why it's not currently in this specification, but I think it could make sense to add it here if you want to open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants