-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select custom arrow #1232
Conversation
packages/components/src/Select.js
Outdated
{arrow ? ( | ||
arrow | ||
) : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{arrow ? ( | |
arrow | |
) : ( | |
{arrow || ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lachlanjc thanks a lot for reviewing - I checked in changes with the simplified syntax
Sweet! Could you update the changelog? (I feel we need a PR template with a todo list) |
What's the difference between this and #1151? |
issue: #1177 #1151
added arrow prop to
Select