New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: field component should use id if passed #1252

Merged

hasparus merged 2 commits into system-ui:master from deckchairlabs:field-component-id

Nov 17, 2020

Contributor

deckchairlabs commented Nov 10, 2020 •

edited

Sometimes a field name is not unique enough. This PR allows passing an id to the field and the related label htmlFor

deckchairlabs added 2 commits

November 10, 2020 18:01


          fix: field component should use id if passed

a124538


          fix: added test

c5d3ae5

Member

hasparus commented Nov 10, 2020

thanks for the PR, @deckchairlabs! Totally agreed.

lachlanjc approved these changes

View reviewed changes

hasparus merged commit 04ed51c into system-ui:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment