Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden props for button doesn't hide button #1254

Closed
cktang88 opened this issue Nov 11, 2020 · 3 comments
Closed

Hidden props for button doesn't hide button #1254

cktang88 opened this issue Nov 11, 2020 · 3 comments

Comments

@cktang88
Copy link

Describe the bug
I tried applying
<Button hidden={true}>hello</Button>
but the button is still visible.

To Reproduce
See above.

Expected behavior
I'd expect the button to be hidden with that attribute.

Screenshots
N/A

Additional context
Using v0.3.1

There was a previous indication this was a bug here: #1253 (comment)

@lachlanjc
Copy link
Member

Do we document somewhere that hidden is an available prop? I’ve never heard of it/seen it in the code.

@atanasster
Copy link
Collaborator

@lachlanjc , hidden is an html attribute that is applicable to all tags, its not a theme-ui thing

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden

@lachlanjc
Copy link
Member

We can close this @hasparus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants