Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min-content on checkbox root #1256

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

deckchairlabs
Copy link
Contributor

Adding min-content as minWidth to checkbox root element prevents clipping on narrow width parents.

@lachlanjc
Copy link
Member

This totally makes sense. Are there any specific default cases you can show where this changes the result? & should we have this on Radio as well?

@deckchairlabs
Copy link
Contributor Author

I've put together a codesandbox showing the result, had to hack it since the root component of both Checkbox and Radio doesn't accept any props. I'll update the PR to include the fix for the Radio component as well.

https://codesandbox.io/s/pedantic-lamport-mr9c6?file=/src/App.tsx

@lachlanjc
Copy link
Member

Amazing, thanks for both of those!

@hasparus hasparus merged commit 2d830f6 into system-ui:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants