Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

throw exception when minifying font-awesome V4.3.0 css #39

Open
areel opened this issue Jun 7, 2015 · 2 comments
Open

throw exception when minifying font-awesome V4.3.0 css #39

areel opened this issue Jun 7, 2015 · 2 comments
Labels

Comments

@areel
Copy link

areel commented Jun 7, 2015

Using bundle-sfx on an app that includes font-awesome.

underlying issue is probably related to
clean-css/clean-css#524.

while investigating this (I haven't read the code closely) I thought it might be useful if the css plugin checked if the file referenced was already minified. This would allow imports statements like:

import 'font-awesome/css/font-awesome.min.css!';

Aidan

@guybedford guybedford added the bug label Jun 8, 2015
@guybedford
Copy link
Member

Sure, I'll look into this when I can. Any suggestions are welcome too.

@areel
Copy link
Author

areel commented Jun 13, 2015

Took another look and the bundle command reports the same error, Bootstrap is also failing

Steps to reproduce

jspm init -y
jspm install css bootstrap 
echo "import _ from 'bootstrap/css/bootstrap.css!';" > app.js
jspm bundle app app-build.js

I tested with the latest version of clean-css(3.3.2) (we are locked on 3.1) issue remains.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants