Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.20 package/paths resolution issue #1552

Closed
ghempton opened this issue Jan 26, 2017 · 3 comments
Closed

0.20 package/paths resolution issue #1552

ghempton opened this issue Jan 26, 2017 · 3 comments

Comments

@ghempton
Copy link

ghempton commented Jan 26, 2017

When using previous version of SystemJS, the configuration looks like this:

SystemJS.config({
  paths: {
    "app/": "modules/app/"
  },
  packages: {
    "app": {
      "format": "register",
      "defaultExtension": "js"
    }
});

After upgrading to 0.20, the app package configuration seems to no longer apply to modules within the package and it does not apply the defaultExtension.

System.import('app/start');

// console error saying it cannot find 'https://localhost:4200/modules/app/start'

If instead I change the configuration to:

SystemJS.config({
  paths: {
    "app/": "modules/app/"
  },
  packages: {
    "modules/app": {
      "format": "register",
      "defaultExtension": "js"
    }
});

It starts to work, but then importing the base module fails:

System.import('app');

It looks like for non-root modules, it is applying path configuration before looking up the package. Is this expected behavior?

@patrickmichalina
Copy link

Same issue here. Had to revert to previous version.

@guybedford
Copy link
Member

Thanks, I've added a fix in 83111de.

@guybedford
Copy link
Member

Released in 0.20.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants