Implement loading of CSS Modules. Resolves #1991. #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
reviewed
Aug 24, 2019
guybedford
approved these changes
Aug 25, 2019
joeldenning
commented
Aug 25, 2019
|
I think it's pretty clear, and we can improve the docs over time as necessary. Will write a clear release description and ship a v6 shortly. Still on the fence over whether it should be a blog post or not, wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1991. Note that in addition to the tests in this PR I verified in a test repo that the css actually gets loaded and can be applied to dom elements.