Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascading import maps implementation #2009

Merged
merged 4 commits into from Aug 29, 2019
Merged

Cascading import maps implementation #2009

merged 4 commits into from Aug 29, 2019

Conversation

guybedford
Copy link
Member

This implements #1999 for cascading import maps resolution, with the implementation behaviours as described in #1999 (comment).

In addition this fixes #2007 that scopes must end in a trailing slash.

The breaking changes are effectively:

  1. Scopes must end in a trailing slash.
  2. Bare specifiers on the RHS of an import map are no longer supported unless in a cascade.

@guybedford guybedford mentioned this pull request Aug 27, 2019
Closed
@guybedford guybedford mentioned this pull request Aug 28, 2019
Closed
joeldenning
joeldenning approved these changes Aug 28, 2019
View reviewed changes
Copy link
Collaborator

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guybedford guybedford mentioned this pull request Aug 28, 2019
Merged
@guybedford guybedford merged commit e6bd2d3 into 6.x Aug 29, 2019
@guybedford guybedford deleted the cascading-import-maps branch August 29, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guybedford @joeldenning