Do not export null as module.exports in amd.js. Resolves #2332. #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging issue-2332 into master will impact 4 files in 3 groups. browser (2/2)
node (1/1)
extras (1/8)
|
guybedford
requested changes
Jun 1, 2021
There was a problem hiding this comment.
Nice work tracking this down. Let's perhaps just make the core code resiliant to null here?
Since this is the problematic line (https://github.com/systemjs/systemjs/blob/master/src/system-core.js#L115):
if (name.__esModule)we could just change that line to:
if (name && name.__esModule)
|
Done! Also added similar for named-exports.js |
guybedford
reviewed
Jun 2, 2021
guybedford
reviewed
Jun 2, 2021
src/extras/amd.js
Outdated
Comment on lines
59
to
61
| // https://github.com/systemjs/systemjs/issues/2332 | ||
| if (module.exports !== null) | ||
| _export(module.exports); |
There was a problem hiding this comment.
With the core change we shouldn't need this null check anymore:
Suggested change
| // https://github.com/systemjs/systemjs/issues/2332 | |
| if (module.exports !== null) | |
| _export(module.exports); |
guybedford
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2332 - both system-core and named-exports do not work if
_export(null)occurs, as it appears to be invalid. However, amd.js would do this as explained in #2332. My fix here is specific only to null, rather than an object check + null check, since it's valid to loop over the keys of functions for re-exporting.