You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is not simple to provide a repro based on the Code Sandbox template provided because this issue is for SystemJS v0.21.6.
Pretty simple to explain though.
If the file being loaded is a minified file, then it detects require calls from inside strings.
For example, when loading this file: https://www.unpkg.com/@tensorflow/tfjs-backend-cpu@3.16.0/dist/tf-backend-cpu.min.js
It imports the @tensorflow/tfjs-node require, which is only found within a string in a console.log('...') call.
This is related to an issue reported here: stackblitz/core#1832
I will be submitting a PR shortly to resolve this issue. 🎉
Expected Behavior
Ignore require(...) statements in strings.
Actual Behavior
When dealing with a minified file, all require statements are parsed, no matter if they are in strings or not.
The text was updated successfully, but these errors were encountered:
markwhitfeld
changed the title
BUG: v0.21.6 detects requires in strings in minified files
BUG: v0.21.6 detects 'requires' in strings in minified files
Apr 30, 2022
Demonstration
It is not simple to provide a repro based on the Code Sandbox template provided because this issue is for SystemJS v0.21.6.
Pretty simple to explain though.
If the file being loaded is a minified file, then it detects
require
calls from inside strings.For example, when loading this file: https://www.unpkg.com/@tensorflow/tfjs-backend-cpu@3.16.0/dist/tf-backend-cpu.min.js
It imports the
@tensorflow/tfjs-node
require, which is only found within a string in aconsole.log('...')
call.This is related to an issue reported here: stackblitz/core#1832
I will be submitting a PR shortly to resolve this issue. 🎉
Expected Behavior
Ignore
require(...)
statements in strings.Actual Behavior
When dealing with a minified file, all require statements are parsed, no matter if they are in strings or not.
The text was updated successfully, but these errors were encountered: