Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourceMappingUrl broken in 6.12.2 #2414

Closed
nilzona opened this issue Aug 18, 2022 · 1 comment · Fixed by #2416
Closed

sourceMappingUrl broken in 6.12.2 #2414

nilzona opened this issue Aug 18, 2022 · 1 comment · Fixed by #2416

Comments

@nilzona
Copy link
Contributor

nilzona commented Aug 18, 2022

Hey @guybedford

source maps are not loading correctly in 6.12.2

looking at the sourceMappingUrl in https://cdn.jsdelivr.net/npm/systemjs@6.12.2/dist/system.min.js the source map url is:
//# sourceMappingURL=##.min.js.map

Compared to https://cdn.jsdelivr.net/npm/systemjs@6.12.1/dist/system.min.js where it is:
//# sourceMappingURL=system.min.js.map

I am not sure, but it looks like it has to do with the hashes in e.g. https://github.com/systemjs/systemjs/blob/main/chompfile.toml#L66 which is picked up by the terser chomp extension in https://github.com/guybedford/chomp-extensions/blob/main/terser.js#L13

@guybedford
Copy link
Member

Thanks @nilzona fixed in #2416, 6.12.3 incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants