Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution Files published to npm do not match what is in GitHub for version 16.14.2 (have windows style line breaks) #2471

Open
erikt9 opened this issue Oct 4, 2023 · 0 comments

Comments

@erikt9
Copy link
Contributor

erikt9 commented Oct 4, 2023

Demonstration

Seems to only effect 16.14.2 and 16.14.3

Install systemjs 16.14.2 via npm

Expected Behavior

The file node_modules/systemjs/dist/system.js should match what is in the version's /dist folder on GitHub and be using unix line breaks. The system.js file should have a size of 34903 bytes (the size of the system.js file when downloaded from GitHub).

Actual Behavior

node_modules/systemjs/dist/system.js has a size of 35908 bytes. When opening and examining it, everything is the same with the github version except there are windows (CRLF) line breaks present.

Main issue is if you are storing something derived from these files in git, git will raise some warnings / complaints about the line endings. I 'build' my distribution of systemjs by running cat on the distribution file with the extras I want which results in a file with windows line breaks.

@erikt9 erikt9 changed the title Files published to npm have windows line breaks(CRLF) Distribution Files published to npm have windows line breaks(CRLF) Oct 4, 2023
@erikt9 erikt9 changed the title Distribution Files published to npm have windows line breaks(CRLF) Distribution Files published to npm do not match what is in GitHub for version 16.14.2 (have windows style line breaks) Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant