Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to secure the correct functionality of the library #1137

Closed
SamuCoco04 opened this issue Mar 9, 2024 · 3 comments
Closed

Suggestion to secure the correct functionality of the library #1137

SamuCoco04 opened this issue Mar 9, 2024 · 3 comments

Comments

@SamuCoco04
Copy link

Hello, doing an analysis with the SonarCloud tool we have been able to detect 11 points that we are not sure work as they should, I find it very difficult to explain the 11 points in a single issue, so I will leave the link to the Sonarcloud section of security hotspots and I highly recommend that someone get to work as it could be compromising the functionality of the library.

https://sonarcloud.io/project/security_hotspots?id=AISSProjects24_ta4j

@gelhaimer
Copy link

It looks like all the issues are all related to ta4jexamples package.

So basically, there is no real "prod" related problem in here.

@gelhaimer gelhaimer mentioned this issue Mar 16, 2024
@TheCookieLab
Copy link
Member

Thanks for bringing this up. Per chance do you feel comfortable creating a pull request to resolve these?

@TheCookieLab
Copy link
Member

TheCookieLab commented May 20, 2024

Reviewed the Sonar issues. Like @gelhaimer stated if these were in ta4j-core then they'd be issues but since they are in ta4jexamples which is not production code, they are fine as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants