Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typo in native_token_support.md #16991

Open
papazeal opened this issue May 4, 2024 · 10 comments
Open

doc: typo in native_token_support.md #16991

papazeal opened this issue May 4, 2024 · 10 comments

Comments

@papazeal
Copy link

papazeal commented May 4, 2024

4. Since our bridge is permissionless, there might have been some USDC bridge operations in the past. It would mean, there is already an existing `BridgedUSDC` on our L2. To overcome liquidity fragmentation, we (Taiko) need to call `ERC20Vault` `changeBridgedToken()` function with the appropriate parameters. This way the "old" `BridgedUSDC` can be migrated to this new native token and the bridging operation will mint into the new token frm that point on.

On line 18, frm should be from the correct sentence should be new token from that point on

@distank
Copy link

distank commented May 13, 2024

good

@otara81
Copy link

otara81 commented May 13, 2024

No no no errooss

@alagbe003
Copy link

good

1 similar comment
@DongyeongK
Copy link

good

@tecsh
Copy link

tecsh commented May 24, 2024

Good

@dinlindin
Copy link

good

1 similar comment
@Liva874
Copy link

Liva874 commented May 24, 2024

good

@pintokin
Copy link

it should be better

@pintokin
Copy link

4. Since our bridge is permissionless, there might have been some USDC bridge operations in the past. It would mean, there is already an existing `BridgedUSDC` on our L2. To overcome liquidity fragmentation, we (Taiko) need to call `ERC20Vault` `changeBridgedToken()` function with the appropriate parameters. This way the "old" `BridgedUSDC` can be migrated to this new native token and the bridging operation will mint into the new token frm that point on.

On line 18, frm should be from the correct sentence should be new token from that point on

focus on productivity, security and performance.

@pintokin
Copy link

focus on productivity, security and performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests