Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: How to correctly configure reverse_proxy for a TLS upstream #25

Closed
t0xa opened this issue Nov 23, 2023 · 1 comment · Fixed by #52
Closed

Question: How to correctly configure reverse_proxy for a TLS upstream #25

t0xa opened this issue Nov 23, 2023 · 1 comment · Fixed by #52

Comments

@t0xa
Copy link

t0xa commented Nov 23, 2023

Hello!

Thank you for this incredible project.

Consider following snippet:

:80 {
   reverse_proxy https://proxmoxvox.ts.net:8006 {
       transport tailscale
   }
}

Error message:

Error: adapting config using caddyfile: parsing caddyfile tokens for 'reverse_proxy': upstreams are configured for HTTPS but transport module does not support TLS: *tscaddy.TailscaleCaddyTransport, at Caddyfile:4

I understand that this limitation related to https://github.com/tailscale/caddy-tailscale#https-support but what would be the right syntax?

Thanks!
willnorris added a commit that referenced this issue May 16, 2024
@willnorris
transport: add TLS support
e227527 
Implement reverseproxy.TLSTransport.  We go ahead and store the provided
TLSConfig object, but for now we only use it to indicate that we should
use TLS.  We don't actually use any of the provided values to configure
the client.

Fixes #25
Fixes #27

Signed-off-by: Will Norris <will@tailscale.com>
willnorris added a commit that referenced this issue May 17, 2024
@willnorris
transport: add TLS support
fa28019 
Implement reverseproxy.TLSTransport.  We go ahead and store the provided
TLSConfig object, but for now we only use it to indicate that we should
use TLS.  We don't actually use any of the provided values to configure
the client.

Fixes #25
Fixes #27

Signed-off-by: Will Norris <will@tailscale.com>
willnorris added a commit that referenced this issue May 17, 2024
@willnorris
transport: add TLS support
2989bce 
Implement reverseproxy.TLSTransport.  We go ahead and store the provided
TLSConfig object, but for now we only use it to indicate that we should
use TLS.  We don't actually use any of the provided values to configure
the client.

Fixes #25

Signed-off-by: Will Norris <will@tailscale.com>
@willnorris willnorris mentioned this issue May 17, 2024
Merged
willnorris added a commit that referenced this issue May 17, 2024
@willnorris
transport: add TLS support
ff64dc8 
Implement reverseproxy.TLSTransport.  We go ahead and store the provided
TLSConfig object, but for now we only use it to indicate that we should
use TLS.  We don't actually use any of the provided values to configure
the client.

Fixes #25

Signed-off-by: Will Norris <will@tailscale.com>
@willnorris
Copy link
Member

we hadn't properly added TLS support for the transport. That should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transport: add TLS support tailscale/caddy-tailscale
2 participants
@willnorris @t0xa